Split announce shard endpoints from comma-separated input in redis editor#1075
Merged
Conversation
…itor Signed-off-by: Arnob Kumar Saha <arnob@appscode.com> Signed-off-by: Samiul <samiul@appscode.com>
* add redis shard validation Signed-off-by: Samiul <samiul@appscode.com> * update validations Signed-off-by: Samiul <samiul@appscode.com> * update validations Signed-off-by: Samiul <samiul@appscode.com> * update validations Signed-off-by: Samiul <samiul@appscode.com> --------- Signed-off-by: Samiul <samiul@appscode.com>
SamiulSourav
force-pushed
the
arnob-redis-shards
branch
from
June 30, 2026 09:22
40d7390 to
c55b679
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The
announce.shardsfield inkubedbcom-redis-editor-optionstakes string input, but the resource expects an array of objects shaped like{ endpoints: ["endpoint1", "endpoint2"] }.Changes
array-item-formtotemp/announceShards(comma-separated string per shard) instead of writing raw strings into the schema path; wireinitandwatcher.setAnnounceShards()— renders existing model shards as comma-joined strings for display.onAnnounceShardsChange()— splits each comma-separated input into{ endpoints: [...] }and commits the correct shape to/spec/cluster/announce/shards.Keeps the model in the schema-required shape, so
isAnnounceValid()'s length-vs-master check still works.